configgrpc: set client info before auth #14267
Open
+93
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14267 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 668 668
Lines 41517 41517
=======================================
+ Hits 38258 38260 +2
+ Misses 2221 2220 -1
+ Partials 1038 1037 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
force-pushed
the
configgrpc-clientinfo-first
branch
from
6e6ba13 to
b495cd2
Compare
This aligns with the confighttp ordering, and ensures server authenticators have access to client info.
axw
force-pushed
the
configgrpc-clientinfo-first
branch
from
b495cd2 to
7e6af89
Compare
dmathieu
approved these changes
Dec 9, 2025
jmacd
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aligns with the confighttp ordering, and ensures server authenticators have access to client info.
Link to tracking issue
Part of #12836
Testing
Added a test.
Documentation
None