-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[exporter/debug] add ability to set output_paths #14164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 23 commits
d1b8a24
fbabe6d
374c202
1e9b18b
d8feeba
5a3232b
b4a6b0e
c08384d
30c8ec3
4b136fd
8bb3be0
d725b74
c3ee29e
fc1885f
15349f4
071b0e3
22f3245
3908483
58b0cad
a88eacb
a2ee4d0
890e9ba
e2d1942
a48ff56
1c1353a
709a284
b8433b6
a288646
743e1db
72905b9
5b31428
435c097
be1255f
2e01494
5038a92
1725f7e
83fe581
25e0e95
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
| component: exporter/debug | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add `output_paths` configuration option to control output destination when `use_internal_logger` is false | ||
|
|
||
| # One or more tracking issues or pull requests related to the change | ||
| issues: [10472] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| When `use_internal_logger` is set to `false`, the debug exporter now supports configuring the output destination via the `output_paths` option. | ||
| This allows users to send debug exporter output to `stdout`, `stderr`, or a file path. | ||
| The default value is `["stdout"]` to maintain backward compatibility. | ||
|
|
||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [] | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,18 @@ func createTestCases() []testCase { | |
| return cfg | ||
| }(), | ||
| }, | ||
| { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a test case for when user sets What should happen then? Shouldn't such config be invalid?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. basically the same thing:
ishaish103 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| name: "custom output paths", | ||
| config: func() *Config { | ||
| cfg := createDefaultConfig().(*Config) | ||
| queueCfg := exporterhelper.NewDefaultQueueConfig() | ||
| queueCfg.QueueSize = 10 | ||
| cfg.QueueConfig = configoptional.Some(queueCfg) | ||
| cfg.UseInternalLogger = false | ||
| cfg.OutputPaths = []string{"stderr"} | ||
| return cfg | ||
| }(), | ||
| }, | ||
| } | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.