-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[exporterhelper] Add exporter_dropped_* reporting capability and metrcs #13704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[exporterhelper] Add exporter_dropped_* reporting capability and metrcs #13704
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13704 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.01%
==========================================
Files 668 668
Lines 41517 41597 +80
==========================================
+ Hits 38258 38329 +71
- Misses 2221 2227 +6
- Partials 1038 1041 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hey, anything I could do to help move this forward? Prometheus exporters drop data based on specification rules, would love to start using the new metric :) |
|
Hello @ArthurSens, yeah ill take a look at this today/tomorrow and update it, sorry for leaving it like this. |
…xporter_dropped_metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @mx-psi, this will be needed to stabilize Prometheus receiver. We currently drop metrics due to spec incompatibility and user can't observe this behavior
Wait, I got confused here lol
This is needed for Prometheus exporters, not the receiver if I'm not mistaken
|
@ArthurSens do you have an issue for what you're describing? I think this issue might be also happening in the receiver side but ill have to investigate that. I can open a PR if I find something related to receiver dropped metrics. |
|
It's part of open-telemetry/opentelemetry-collector-contrib#39706, we need to have a metric explaining when metrics are dropped. For the Prometheus exporters for example, we currently drop Delta metrics because Prometheus doesn't support deltas |
|
Is there anything else I could do here to get this merged? |
Description
Add exporter_dropped_* metrics to track dropped items, allowing exporter devs to report back the number of dropped items.
Link to tracking issue
Fixes #13643
Documentation
Added instructions for exporter devs