Skip to content

Conversation

@bogdan-st
Copy link

Description

Add exporter_dropped_* metrics to track dropped items, allowing exporter devs to report back the number of dropped items.

Link to tracking issue

Fixes #13643

Documentation

Added instructions for exporter devs

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 12, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (97fcd3d) to head (7d08f95).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13704      +/-   ##
==========================================
- Coverage   92.15%   92.14%   -0.01%     
==========================================
  Files         668      668              
  Lines       41517    41597      +80     
==========================================
+ Hits        38258    38329      +71     
- Misses       2221     2227       +6     
- Partials     1038     1041       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the Stale label Sep 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 8, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 24, 2025
@ArthurSens
Copy link
Member

Hey, anything I could do to help move this forward? Prometheus exporters drop data based on specification rules, would love to start using the new metric :)

@bogdan-st
Copy link
Author

Hello @ArthurSens, yeah ill take a look at this today/tomorrow and update it, sorry for leaving it like this.

@github-actions github-actions bot removed the Stale label Oct 28, 2025
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @mx-psi, this will be needed to stabilize Prometheus receiver. We currently drop metrics due to spec incompatibility and user can't observe this behavior

Wait, I got confused here lol
This is needed for Prometheus exporters, not the receiver if I'm not mistaken

@bogdan-st
Copy link
Author

@ArthurSens do you have an issue for what you're describing? I think this issue might be also happening in the receiver side but ill have to investigate that. I can open a PR if I find something related to receiver dropped metrics.

@ArthurSens
Copy link
Member

It's part of open-telemetry/opentelemetry-collector-contrib#39706, we need to have a metric explaining when metrics are dropped. For the Prometheus exporters for example, we currently drop Delta metrics because Prometheus doesn't support deltas

@bogdan-st
Copy link
Author

Is there anything else I could do here to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal telemetry of Prometheus exporter incorrectly reports dropped metrics as "Sent"

3 participants