-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[configgrpc] Make TCP the default transport type #13673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configgrpc] Make TCP the default transport type #13673
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13673 +/- ##
==========================================
+ Coverage 91.37% 91.38% +0.01%
==========================================
Files 633 633
Lines 39723 39727 +4
==========================================
+ Hits 36295 36303 +8
+ Misses 2670 2667 -3
+ Partials 758 757 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking because I fail to understand how http2 implies TCP.
|
The HTTP/2 protocol is based on TCP. Maybe you're thinking of HTTP/3, which abandoned it in favor of UDP? |
It is a bit subtle than that, because HTTP/2 can also be configured to use UDS which is not really TCP, so this is not always true. Also, Gemini answered: |
|
@bogdandrutu I reworded the comment to instead say that we want to listen over the network in most cases. |
Description
Most gRPC servers are serving over HTTP/2, so use TCP as the default transport type.
Link to tracking issue
Fixes #13657