Skip to content

Conversation

@evan-bradley
Copy link
Contributor

Description

Most gRPC servers are serving over HTTP/2, so use TCP as the default transport type.

Link to tracking issue

Fixes #13657

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (6db802a) to head (bb3959e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13673      +/-   ##
==========================================
+ Coverage   91.37%   91.38%   +0.01%     
==========================================
  Files         633      633              
  Lines       39723    39727       +4     
==========================================
+ Hits        36295    36303       +8     
+ Misses       2670     2667       -3     
+ Partials      758      757       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because I fail to understand how http2 implies TCP.

@jade-guiton-dd
Copy link
Contributor

jade-guiton-dd commented Aug 19, 2025

The HTTP/2 protocol is based on TCP. Maybe you're thinking of HTTP/3, which abandoned it in favor of UDP?

@bogdandrutu
Copy link
Member

bogdandrutu commented Aug 19, 2025

The HTTP/2 protocol is based on TCP. Maybe you're thinking of HTTP/3, which abandoned it in favor of UDP?

It is a bit subtle than that, because HTTP/2 can also be configured to use UDS which is not really TCP, so this is not always true.

Also, Gemini answered:

Yes, HTTP/2 typically relies on TCP as its underlying transport protocol. While HTTP/2 can technically
function without TLS (which uses TCP), it's not the standard practice for external traffic. In most cases,
HTTP/2 utilizes TCP for its connection-based and reliable data transfer characteristics. 

@evan-bradley
Copy link
Contributor Author

@bogdandrutu I reworded the comment to instead say that we want to listen over the network in most cases.

@bogdandrutu bogdandrutu dismissed their stale review August 19, 2025 17:44

Reason for blocking fixed

@bogdandrutu bogdandrutu added this pull request to the merge queue Aug 20, 2025
Merged via the queue into open-telemetry:main with commit 6de2488 Aug 20, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[configgrpc] Default to TCP transport

3 participants