[exporterhelper] Validate Queue.Batch config #13580
Conversation
| if err := cfg.Batch.Get().Validate(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Can we change https://github.com/open-telemetry/opentelemetry-collector/blob/main/confmap/xconfmap/config.go#L28 to call this for us?
There was a problem hiding this comment.
The reason is that we use that in Service and ask everyone to not manually call Validate for embedded fields. So I think this should work for this case as well.
There was a problem hiding this comment.
That's the issue #13579
I am a bit confused why you suggest xconfmap.
There was a problem hiding this comment.
Well, now I see that xconfmap is where this code lives (thought it was confmap).
#13579 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13580 +/- ##
==========================================
- Coverage 92.15% 92.08% -0.07%
==========================================
Files 605 605
Lines 31827 31831 +4
==========================================
- Hits 29329 29313 -16
- Misses 1973 1988 +15
- Partials 525 530 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This was rolled into #13611. |
2 participants
Description
The QueueBatch is not validating Batch configuration.
I may have expected the configoptional package to handle the validate reflection and do this automatically (?) but it doesn't.
Addresses missing error, see regression fixed in open-telemetry/opentelemetry-collector-contrib#41830.
Link to tracking issue
Part of #13579
Testing
Added
Documentation
n/a