Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Jul 29, 2025

This should fix the recent failure in #13507

@trask trask requested a review from a team as a code owner July 29, 2025 03:23
@trask trask requested a review from dmitryax July 29, 2025 03:23
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.00%. Comparing base (96f9a35) to head (aa3cc7d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13516      +/-   ##
==========================================
- Coverage   92.02%   92.00%   -0.02%     
==========================================
  Files         531      531              
  Lines       31045    31045              
==========================================
- Hits        28568    28564       -4     
- Misses       1951     1954       +3     
- Partials      526      527       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 29, 2025
@bogdandrutu bogdandrutu enabled auto-merge July 29, 2025 04:09
@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 29, 2025
Merged via the queue into open-telemetry:main with commit 8797b3e Jul 29, 2025
76 of 77 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2025
#### Description

Based on [this debug
log](https://github.com/open-telemetry/opentelemetry-collector/actions/runs/17922024987/job/50959147505),
we can now tell that the payload passed to the merge freeze job in the
merge queue CI for otelbot PRs has `author.name = "otelbot[bot]"` and
`author.email = "197425009+otelbot[bot]@users.noreply.github.com"`.

That email is extremely surprising considering [the patch output for
otelbot's
commits](https://github.com/open-telemetry/opentelemetry-collector/commit/8e24523e66c3acfeb18dd3086f7f198f3953bae5.patch)
has almost the same email, but without the `[bot]` suffix...

This PR reverts back to a name-based check for simplicity, and removes
the debug log. The result is very similar to #13516, but checking
against the correct name.

#### Link to tracking issue
Fixes #13789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants