Downgrade otel-go (#13429) #13466
Merged
Downgrade otel-go (#13429) #13466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Downgrades opentelemetry-go dependencies effectively reverting open-telemetry#13289 and others - Due to a [bug](open-telemetry/opentelemetry-go#7039) in the prometheus exporter, if you are configuring a prometheus exporter, the collector's internal metrics will be emitted with an unexpected suffix in its name. For example, the metric `otelcol_exporter_sent_spans__spans__total` instead of `otelcol_exporter_sent_spans_total`. The workaround is to manually configure `without_units: true` in your prometheus exporter config ```yaml service: telemetry: metrics: readers: - pull: exporter: prometheus: host: 0.0.0.0 port: 8888 without_units: true ``` If you are using the collector's default Prometheus exporter for exporting internal metrics you are unaffected. --------- Signed-off-by: alex boten <[email protected]> Co-authored-by: alex boten <[email protected]> Co-authored-by: Yang Song <[email protected]>
songy23
requested review from
a team,
andrzej-stencel,
bogdandrutu,
dmathieu,
dmitryax,
evan-bradley and
mx-psi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13466 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 533 533
Lines 29564 29566 +2
=======================================
+ Hits 27034 27036 +2
Misses 1998 1998
Partials 532 532 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
added
the
release:blocker
mx-psi
approved these changes
Jul 23, 2025
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
@ArthurSens @dashpole would appreciate a review from your side, thx!
codeboten
approved these changes
Jul 23, 2025
Contributor
|
Is there a new bug opened to track this in prometheus? |
dmathieu
approved these changes
Jul 23, 2025
Member
Author
looks like it's prometheus/otlptranslator#44 |
This was referenced Jul 31, 2025
songy23
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 8, 2025
…41869) #### Description Similar to open-telemetry/opentelemetry-collector-releases#1067 but for contrib This avoids accidentally pulling in go.opentelemetry.io/otel/exporters/prometheus v0.59.x when building your distros. v0.59.x has a known bug in metric names. See open-telemetry/opentelemetry-collector#13466. #### Link to tracking issue open-telemetry/opentelemetry-collector#13544
obs-gh-mattcotter
added a commit
to observeinc/observe-agent
that referenced
this pull request
Aug 29, 2025
…and status check (#255) Context: open-telemetry/opentelemetry-collector#13466 go.opentelemetry.io/otel/exporters/prometheus v0.59.x has a bug leading to unexpected suffix in metric names, we need to stay with v0.58.0 to make `observe-agent status` work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick of d82267d
go.opentelemetry.io/otel/exporters/prometheus v0.59.1does not fully fix the metric name issue so we have to revert to v0.58.0Downgrades opentelemetry-go dependencies effectively reverting #13289 and others
otelcol_exporter_sent_spans__spans__totalinstead ofotelcol_exporter_sent_spans_total. The workaround is to manually configurewithout_units: truein your prometheus exporter configIf you are using the collector's default Prometheus exporter for exporting internal metrics you are unaffected.