[exporterhelper] Fix metric name preservation during request splitting #13238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve an issue in where metric names were lost when splitting objects. Updated logic now ensures all metric fields, including names, are retained across splitting operations. Added relevant tests to validate the fix.
bogdandrutu
reviewed
Jun 19, 2025
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
If there is a bug please add a test to reproduce it
bogdandrutu
reviewed
Jun 20, 2025
bogdandrutu
requested changes
Jun 20, 2025
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
See comment about new added bug. Please add tests
Ensure metric metadata is copied when splitting data points by adding a `CopyTo` call. Added comprehensive test coverage to verify correct behavior for various metric types and scenarios.
Previously, RequestSizerTypeBytes was calculating datapoint size incorrectly due to the omission of 'name', 'description', and 'unit' fields. This commit rectifies the calculation by including these fields.
Contributor
Author
@bogdandrutu |
jmacd
approved these changes
Jun 23, 2025
This update ensures that metadata is copied from source to destination metrics during transformation. Tests have been updated to validate metadata handling, including verifying key-value pairs in the metadata.
Contributor
Author
|
@bogdandrutu |
dmathieu
reviewed
Jun 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13238 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 526 526
Lines 29398 29406 +8
=======================================
+ Hits 26938 26946 +8
Misses 1944 1944
Partials 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Damien Mathieu <[email protected]>
dmathieu
approved these changes
Jun 25, 2025
Contributor
Author
|
@bogdandrutu |
bogdandrutu
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in exporter/exporterhelper's sending_queue where metric names were lost during metricRequest splitting. Previously, when large batches of metrics were processed, the splitting logic in metric_batch.go could cause the name field of some metrics to disappear. This fix ensures that all metric fields are properly preserved when metricRequest objects are split.
Link to tracking issue
Fixes #13236