-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Introduce FromLocationIndices and PutLocation #13150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Introduce FromLocationIndices and PutLocation #13150
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (83.63%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13150 +/- ##
==========================================
+ Coverage 91.26% 91.28% +0.02%
==========================================
Files 508 512 +4
Lines 28747 28790 +43
==========================================
+ Hits 26235 26282 +47
+ Misses 1994 1992 -2
+ Partials 518 516 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Description
This introduces the
FromLocationIndices
andPutLocation
methods, as we have for attributes.https://github.com/open-telemetry/opentelemetry-collector/blob/main/pdata/pprofile/attributes.go
The intent is to be able to use this to perform merging/batching of profiles.
I will be adding similar methods for the other tables once the concept of this first PR is validated.
Benchmark Results