[componentattribute] Use otelzap.WithAttributes, remove LoggerProviderWithAttributes #13108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-guiton-dd
added
the
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13108 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 506 505 -1
Lines 28534 28517 -17
=======================================
- Hits 26137 26123 -14
+ Misses 1882 1880 -2
+ Partials 515 514 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
approved these changes
May 29, 2025
codeboten
approved these changes
May 30, 2025
Merged
via the queue into
open-telemetry:main
with commit May 30, 2025
7ff2465
62 of 66 checks passed
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 3, 2025
…rWithAttributes (open-telemetry#13108) #### Description Now that `otelzap` has been bumped up to 0.11.0 (open-telemetry#13103), this PR follows up on a TODO comment to use open-telemetry/opentelemetry-go-contrib#6962 to set instrumentation scope attributes on the Logger created by otelzap, instead of a workaround (`LoggerProviderWithAttributes`). This is an internal change, and the new code should be functionally equivalent, so I don't think this needs a changelog. #### Testing I believe this is already covered by existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that
otelzaphas been bumped up to 0.11.0 (#13103), this PR follows up on a TODO comment to use open-telemetry/opentelemetry-go-contrib#6962 to set instrumentation scope attributes on the Logger created by otelzap, instead of a workaround (LoggerProviderWithAttributes).This is an internal change, and the new code should be functionally equivalent, so I don't think this needs a changelog.
Testing
I believe this is already covered by existing tests.