Skip to content

confighttp: make server span naming spec-compliant #13088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

axw
Copy link
Contributor

@axw axw commented May 26, 2025

Description

Update the confighttp server span names to use the low-cardnality request pattern, rather than the full client-specified path, as described by the specification: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#name.

Requires open-telemetry/opentelemetry-go-contrib#7192

Link to tracking issue

Fixes #12468

Testing

Added a unit test.

Documentation

None

github-merge-queue bot pushed a commit that referenced this pull request May 27, 2025
This bumps all but the otelconf package. Part of
#13098 and
unblocks
#13088

---------

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codeboten
Copy link
Contributor

@axw this should be unblocked now that the deps update has been merged

Update the confighttp server span names to use
the low-cardnality request pattern, rather than
the full client-specified path, as described by
the specification.
@axw axw force-pushed the confighttp-server-pattern-spanname branch from e801c94 to 8b7e395 Compare May 28, 2025 03:08
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (9b4911b) to head (3e1c30d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13088   +/-   ##
=======================================
  Coverage   91.59%   91.60%           
=======================================
  Files         505      506    +1     
  Lines       28479    28544   +65     
=======================================
+ Hits        26085    26147   +62     
- Misses       1880     1882    +2     
- Partials      514      515    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw axw marked this pull request as ready for review May 28, 2025 03:42
@axw axw requested a review from a team as a code owner May 28, 2025 03:42
@axw axw requested a review from atoulme May 28, 2025 03:42
@codeboten codeboten enabled auto-merge May 28, 2025 15:38
@codeboten codeboten added this pull request to the merge queue May 28, 2025
Merged via the queue into open-telemetry:main with commit 4a37179 May 28, 2025
56 checks passed
@axw axw deleted the confighttp-server-pattern-spanname branch May 29, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confighttp] otelhttp-generated span names may have high cardinality
3 participants