[PoC] Test alternative configoptional implementation #13060
Draft
+659
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/configoptional-enabled
branch
2 times, most recently
from
9fbc1b8 to
115fb2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13060 +/- ##
==========================================
+ Coverage 91.58% 91.60% +0.01%
==========================================
Files 505 506 +1
Lines 28319 28359 +40
==========================================
+ Hits 25937 25977 +40
Misses 1873 1873
Partials 509 509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
force-pushed
the
mx-psi/configoptional-enabled
branch
from
115fb2c to
c11701a
Compare
mx-psi
force-pushed
the
mx-psi/configoptional-enabled
branch
from
c11701a to
3ef60da
Compare
|
This mostly works but I would need #13064 to avoid some quirks with expanded values |
yurishkuro
reviewed
May 21, 2025
| // The zero value of Optional is None. | ||
| type Optional[T any] struct { | ||
| // Enabled indicates if the value is present. | ||
| Enabled bool `mapstructure:"enabled"` |
There was a problem hiding this comment.
Left a response on the original PR #13044 (comment). IMO adding enabled directly to the optional type is an abstraction leak, it does not need to be done at the framework level, the user always has the option of adding it explicitly to T.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a method to delete a path from a `Conf` object. I needed this for #13060 --------- Co-authored-by: Jade Guiton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements alternative described here: #13044 (comment)