-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove deprecated old batcher config #13003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
774261c
to
af738b5
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
af738b5
to
f47f75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can remove it until #12879 is resolved
These are different issues. the deprecated config also does not support "request" batching. |
Right, but the problem is that persistent storage can only work with |
But this is the current behavior, right? Maybe an error can be returned if the user tries to use that queue with a different sizer (until it is implemented). |
No, currently users can configure persistent queue with the batcher using the old batcher config interface |
Since this is "experimental" feature, still not sure we should block this... but for the moment, if in this version we don't have a solution for your problem @dmitryax I suggest we move forward. |
Why do we need to remove this urgently? I think we should have a migration path without introducing regressions |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
No description provided.