Skip to content

Remove deprecated old batcher config #13003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu changed the title [mdatagen] Add functions for processing structured events (#12961) Remove deprecated old batcher config May 8, 2025
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can remove it until #12879 is resolved

@bogdandrutu
Copy link
Member Author

bogdandrutu commented May 8, 2025

I don't think we can remove it until #12879 is resolved

These are different issues. the deprecated config also does not support "request" batching.

See https://github.com/open-telemetry/opentelemetry-collector/pull/13003/files#diff-45d09df1b12e28cfc26a0bc617f391a559334fed9a5df242fd179ad5e85fe3e0L141

@dmitryax
Copy link
Member

dmitryax commented May 8, 2025

These are different issues. the deprecated config also does not support "request" batching.

See https://github.com/open-telemetry/opentelemetry-collector/pull/13003/files#diff-45d09df1b12e28cfc26a0bc617f391a559334fed9a5df242fd179ad5e85fe3e0L141

Right, but the problem is that persistent storage can only work with requests sizer. Having the old batcher config allows us to use items for batcher and requests for persistent queue. If the old batch interface is removed, users won't be able to use the persistent queue with the batcher at all because there only one sizer can be configured for both.

@iblancasa
Copy link
Contributor

If the old batch interface is removed, users won't be able to use the persistent queue with the batcher at all because there only one sizer can be configured for both.

But this is the current behavior, right? Maybe an error can be returned if the user tries to use that queue with a different sizer (until it is implemented).

@dmitryax
Copy link
Member

dmitryax commented May 15, 2025

But this is the current behavior, right? Maybe an error can be returned if the user tries to use that queue with a different sizer (until it is implemented).

No, currently users can configure persistent queue with the batcher using the old batcher config interface

@bogdandrutu
Copy link
Member Author

Since this is "experimental" feature, still not sure we should block this... but for the moment, if in this version we don't have a solution for your problem @dmitryax I suggest we move forward.

@dmitryax
Copy link
Member

Why do we need to remove this urgently? I think we should have a migration path without introducing regressions

Copy link
Contributor

github-actions bot commented Jun 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants