Skip to content

[confmap] use DeepEqual when using confmap.enableMergeAppendOption #12952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2025

Conversation

VihasMakwana
Copy link
Contributor

Description

Equal(..) panics when we're comparing maps. Use reflect.DeepEqual instead. It behaves same way as Equal for types such as int, string, float etc, but compares individual elements for maps as well.

Link to tracking issue

Fixes #12932

Testing

Added a scenario

Documentation

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (c4b6423) to head (53c0a4a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12952   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         503      503           
  Lines       27550    27555    +5     
=======================================
+ Hits        25262    25267    +5     
  Misses       1808     1808           
  Partials      480      480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax dmitryax added this pull request to the merge queue May 1, 2025
Merged via the queue into open-telemetry:main with commit 727ae96 May 1, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when using confmap.enableMergeAppendOption
2 participants