Skip to content

add storage full error to xextension/storage #12925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

mattsains
Copy link
Contributor

@mattsains mattsains commented Apr 25, 2025

Description

This adds an error for when the storage extension runs out of space. Extensions can return this error when it's not possible to store data because the maximum allowable/possible space has been reached.

Link to tracking issue

Fixes #12634

Testing

I have been working on the filestorage extension and have a draft PR that uses this error: open-telemetry/opentelemetry-collector-contrib#39667

@mattsains mattsains requested a review from a team as a code owner April 25, 2025 19:45
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (f26c6bb) to head (5446012).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12925   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         499      499           
  Lines       27425    27425           
=======================================
  Hits        25140    25140           
  Misses       1806     1806           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Apr 28, 2025
Merged via the queue into open-telemetry:main with commit 4ed72bd Apr 28, 2025
57 checks passed
@mattsains mattsains deleted the storage-max branch April 28, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage extension interface should define error for when the storage is full
3 participants