[exporterhelper] Do not ignore the num_consumers setting when batching is enabled
#12921
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
num_consumers setting when batching is enablednum_consumers setting when batching is enabled
dmitryax
changed the title
num_consumers setting when batching is enablednum_consumers setting when batching is enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12921 +/- ##
==========================================
- Coverage 91.66% 91.66% -0.01%
==========================================
Files 499 499
Lines 27426 27425 -1
==========================================
- Hits 25141 25140 -1
Misses 1806 1806
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I saw your comment about sending batches, that is already distributed if I am not mistaken, and it always create a new goroutine for exporting |
|
@bogdandrutu it is distributed but limited by the number of workers which is set to the |
|
You are right this is a bug, we should set num consumers after initialization of the batch to 1… need to push this asap |
bogdandrutu
approved these changes
Apr 25, 2025
bogdandrutu
reviewed
Apr 25, 2025
Remove hardcoding the number of queue workers to one if batching is enabled. The bug described in open-telemetry#12244 isn't relevant anymore.
dmitryax
force-pushed
the
batciher-remove-workers-restriction
branch
from
f42b88e to
0d1d2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoding the number of queue workers to one if batching is enabled. The bug described in #12244 isn't relevant anymore.