Middleware: HTTP support (part 3/4) #12845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Apr 17, 2025
bogdandrutu
approved these changes
Apr 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12845 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 499 499
Lines 27052 27076 +24
=======================================
+ Hits 24764 24788 +24
Misses 1809 1809
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
approved these changes
Apr 18, 2025
| // HTTPClientFunc implements an HTTP client middleware function. This | ||
| // is the equivalent of net/http.HandlerFunc for creating a | ||
| // net/http.RoundTripper from a function. | ||
| type HTTPClientFunc func(*http.Request) (*http.Response, error) |
There was a problem hiding this comment.
RoundTripperFunc to be consistent with http.HandlerFunc?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2025
…nc (#12895) #### Description Fixes #12845 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the HTTP middleware support from #12842.
Link to tracking issue
Part of #12603.
Testing
Yes.
Documentation
Added.