Skip to content

Middleware: config struct (part 2/4) #12844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 15, 2025

Description

Adds the config struct from #12842.

Link to tracking issue

Part of #12603.

Testing

Yes. This PR introduces extensionmiddlewaretest helpers.

Documentation

Added.

@jmacd jmacd requested a review from a team as a code owner April 15, 2025 00:57
@jmacd jmacd requested a review from dmitryax April 15, 2025 00:57
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this in version.yaml.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments about consistency and config

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (d79ffd3) to head (568d525).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12844      +/-   ##
==========================================
+ Coverage   91.52%   91.54%   +0.02%     
==========================================
  Files         494      499       +5     
  Lines       26983    27047      +64     
==========================================
+ Hits        24695    24759      +64     
  Misses       1809     1809              
  Partials      479      479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu
Copy link
Member

@jmacd please run make gotidy :)

@bogdandrutu bogdandrutu added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2025
@bogdandrutu bogdandrutu enabled auto-merge April 17, 2025 17:35
@bogdandrutu bogdandrutu added this pull request to the merge queue Apr 17, 2025
Merged via the queue into open-telemetry:main with commit 4610126 Apr 17, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants