-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Middleware: config struct (part 2/4) #12844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middleware: config struct (part 2/4) #12844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add this in version.yaml.
…tor into jmacd/configmiddle_2_configmiddle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some comments about consistency and config
extension/extensionmiddleware/extensionmiddlewaretest/error_client.go
Outdated
Show resolved
Hide resolved
…tor into jmacd/configmiddle_2_configmiddle
…tor into jmacd/configmiddle_2_configmiddle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12844 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.02%
==========================================
Files 494 499 +5
Lines 26983 27047 +64
==========================================
+ Hits 24695 24759 +64
Misses 1809 1809
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Bogdan Drutu <[email protected]>
…opentelemetry-collector into jmacd/configmiddle_2_configmiddle
@jmacd please run |
…tor into jmacd/configmiddle_2_configmiddle
…tor into jmacd/configmiddle_2_configmiddle
Description
Adds the config struct from #12842.
Link to tracking issue
Part of #12603.
Testing
Yes. This PR introduces
extensionmiddlewaretest
helpers.Documentation
Added.