add GetFactory interface to hostcapabilities package #12789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12789 +/- ##
==========================================
- Coverage 91.46% 91.43% -0.04%
==========================================
Files 483 487 +4
Lines 26624 26808 +184
==========================================
+ Hits 24351 24511 +160
- Misses 1791 1814 +23
- Partials 482 483 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jade-guiton-dd
requested changes
Apr 7, 2025
There was a problem hiding this comment.
Looks good to me, just a small update to the release notes.
@TylerHelmuth since you previously removed this method from the component.Host interface: are there any plans to deprecate/modify the method that would make exposing this interface counter-productive?
Co-authored-by: Jade Guiton <[email protected]>
It doesn't seem likely that we'll remove this capability from our |
TylerHelmuth
approved these changes
Apr 10, 2025
jade-guiton-dd
approved these changes
Apr 10, 2025
atoulme
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Use core collector API for interface validation open-telemetry/opentelemetry-collector#12789 <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: Antoine Toulme <[email protected]>
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…elemetry#39453) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Use core collector API for interface validation open-telemetry/opentelemetry-collector#12789 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: Antoine Toulme <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…elemetry#39453) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Use core collector API for interface validation open-telemetry/opentelemetry-collector#12789 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GetFactory method is used by a few receivers in the contrib package (e.g. receiver_creator). This PR adds a new interface to the hostcapabilities package so it can be cast correctly from other packages/components.
Link to tracking issue
Fixes #
Testing
Documentation