Replace exporterhelper Request.Export with passing a ConsumeRequest func #12637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
rm-request-export
branch
from
922b424 to
732596c
Compare
bogdandrutu
force-pushed
the
rm-request-export
branch
2 times, most recently
from
87c818e to
5bc51a4
Compare
|
Sounds good to me. This would resolve #8950. Please take a look at the failing CI |
bogdandrutu
force-pushed
the
rm-request-export
branch
2 times, most recently
from
9ce643e to
ed16315
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12637 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 478 479 +1
Lines 26456 26481 +25
=======================================
+ Hits 24250 24273 +23
- Misses 1747 1749 +2
Partials 459 459 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
force-pushed
the
rm-request-export
branch
3 times, most recently
from
839e22e to
c1cb1b5
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rm-request-export
branch
from
c1cb1b5 to
ba96c23
Compare
|
@dmitryax PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8950
The logic behind this, is that during merging and splitting we should not care about the export func (see complicated logic removed in FakeRequest of in the pdata requests implementations).
Also, this simplify what user should carry with the request.