Limiter extension configgrpc integration draft #12600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Mar 11, 2025
Comment on lines
+192
to
+195
| // Limiters are a collection of limiter extensions. Each | ||
| // Limitation names an extension that is expected to implement | ||
| // limiter.Extension. They are called in order. | ||
| Limiters []configlimiter.Limitation `mapreduce:"limiters"` |
There was a problem hiding this comment.
Not sure I can see a case with multiple limiters, but it is ok I believe. Maybe in the PR description add a case where you can see multiple limiters being used.
bogdandrutu
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Confused a bit about limiter vs limit (#12601) but otherwise config/ changes are ok, please update configlimiter to configlimit if we go with that.
| @@ -478,6 +485,8 @@ func (gss *ServerConfig) getGrpcServerOptions( | |||
| var uInterceptors []grpc.UnaryServerInterceptor | |||
| var sInterceptors []grpc.StreamServerInterceptor | |||
|
|
|||
| // Initialize the auth extension first. | |||
There was a problem hiding this comment.
Please add in the comment if there is any specific reason.
| } | ||
| limitExts = append(limitExts, lim) | ||
| } | ||
| if limitExts != nil { |
There was a problem hiding this comment.
It is a best practice to compare len with 0 than the slice with nil.
|
See #12603 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demonstrates how a
Limiters []limter.Limiterwill be threaded through the gRPC ServerConfig struct, allowing limiters to integrate with gRPC servers easily.Link to tracking issue
Part of #9591.
Testing
TODO
Documentation
TODO