-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[chore] Create RFC for Optional config types #12596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Create RFC for Optional config types #12596
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12596 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 499 499
Lines 27102 27102
=======================================
Hits 24814 24814
Misses 1809 1809
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@yurishkuro could you take a look at this? We're taking a closer look at whether we want this type for 1.0 and want to make sure if we add it that it will cover all config use cases and won't have any major downsides. I would appreciate your input here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can then remove https://github.com/open-telemetry/opentelemetry-collector/blob/main/confmap/confmap.go#L351
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cc @open-telemetry/collector-approvers This has entered final comment period, I intend to merge this on Friday if there are no further blocking comments |
I believe none of the pending conversations are blocking, but I pinged the authors just in case. |
Description
This RFC will help us explore the use cases Optional types solve and move us toward a resolution for whether to adopt these in our config.
Related to #10266