Skip to content

[chore] Create RFC for Optional config types #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2025

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Mar 10, 2025

Description

This RFC will help us explore the use cases Optional types solve and move us toward a resolution for whether to adopt these in our config.

Related to #10266

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (bac08e2) to head (939fa0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12596   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         499      499           
  Lines       27102    27102           
=======================================
  Hits        24814    24814           
  Misses       1809     1809           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evan-bradley
Copy link
Contributor Author

@yurishkuro could you take a look at this? We're taking a closer look at whether we want this type for 1.0 and want to make sure if we add it that it will cover all config use cases and won't have any major downsides. I would appreciate your input here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

github-actions bot commented Apr 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 2, 2025
@evan-bradley evan-bradley added rfc:final-comment-period This RFC is in the final comment period phase and removed Stale labels Apr 8, 2025
@github-actions github-actions bot requested a review from bogdandrutu April 8, 2025 07:29
@mx-psi
Copy link
Member

mx-psi commented Apr 8, 2025

cc @open-telemetry/collector-approvers This has entered final comment period, I intend to merge this on Friday if there are no further blocking comments

@mx-psi
Copy link
Member

mx-psi commented Apr 14, 2025

I believe none of the pending conversations are blocking, but I pinged the authors just in case.

@mx-psi mx-psi enabled auto-merge April 21, 2025 10:47
@mx-psi mx-psi added this pull request to the merge queue Apr 21, 2025
Merged via the queue into open-telemetry:main with commit 901c395 Apr 21, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc:final-comment-period This RFC is in the final comment period phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants