-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Propagate telemetry.resource to the internal logs #12583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test when used in combination with the otlp exporter for logs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12583 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 501 503 +2
Lines 27506 27559 +53
=======================================
+ Hits 25221 25271 +50
- Misses 1806 1808 +2
- Partials 479 480 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test added. |
Can you check again @bogdandrutu? Thanks! |
@open-telemetry/collector-approvers can somebody take a look to this PR? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I have some concerns related to my comment on the tracking issue however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, but I'll leave it to @bogdandrutu to evaluate whether the test he requested is no longer necessary.
Thanks a lot for your time to review and your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, since this PR no longer affects the export of logs through OTLP, I don't think the test requested by Bogdan makes sense anymore. Approving.
@open-telemetry/collector-maintainers can somebody take a look there? |
Hey, could you take a look to this PR? @bogdandrutu @sfc-gh-bdrutu |
Ping @open-telemetry/collector-approvers |
@bogdandrutu @sfc-gh-bdrutu ready for review |
Signed-off-by: Israel Blancas <[email protected]>
I think everything should be ok now, @bogdandrutu @sfc-gh-bdrutu |
@open-telemetry/collector-approvers could somebody merge this? Thanks! |
5ee4816
Thanks for this fix @iblancasa, this makes me wonder if at some point we'd be able to switch to using a console exporter to ensure consistency in the future |
Description
Propagate
telemetry.resource
to the internal logs.Link to tracking issue
Fixes #12582