Skip to content

Propagate telemetry.resource to the internal logs #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

iblancasa
Copy link
Contributor

Description

Propagate telemetry.resource to the internal logs.

Link to tracking issue

Fixes #12582

@iblancasa iblancasa requested a review from a team as a code owner March 7, 2025 16:37
@iblancasa iblancasa requested a review from songy23 March 7, 2025 16:37
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test when used in combination with the otlp exporter for logs

@iblancasa iblancasa changed the title Propagate telemetry.resource to the internal logs. #12582 Propagate telemetry.resource to the internal logs Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (2ecd0b7) to head (e2c2f91).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12583   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         501      503    +2     
  Lines       27506    27559   +53     
=======================================
+ Hits        25221    25271   +50     
- Misses       1806     1808    +2     
- Partials      479      480    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iblancasa
Copy link
Contributor Author

Please add a test when used in combination with the otlp exporter for logs

Test added.

@iblancasa
Copy link
Contributor Author

Can you check again @bogdandrutu? Thanks!

@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-approvers can somebody take a look to this PR? Thank you

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I have some concerns related to my comment on the tracking issue however.

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, but I'll leave it to @bogdandrutu to evaluate whether the test he requested is no longer necessary.

@iblancasa
Copy link
Contributor Author

This looks good to me now, but I'll leave it to @bogdandrutu to evaluate whether the test he requested is no longer necessary.

Thanks a lot for your time to review and your help.

@iblancasa iblancasa requested a review from jade-guiton-dd April 3, 2025 12:57
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, since this PR no longer affects the export of logs through OTLP, I don't think the test requested by Bogdan makes sense anymore. Approving.

@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-maintainers can somebody take a look there?

@iblancasa
Copy link
Contributor Author

Hey, could you take a look to this PR? @bogdandrutu @sfc-gh-bdrutu

@iblancasa
Copy link
Contributor Author

ping @bogdandrutu @sfc-gh-bdrutu

@iblancasa
Copy link
Contributor Author

Ping @open-telemetry/collector-approvers

@iblancasa
Copy link
Contributor Author

@bogdandrutu @sfc-gh-bdrutu ready for review

@iblancasa
Copy link
Contributor Author

I think everything should be ok now, @bogdandrutu @sfc-gh-bdrutu

@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-approvers could somebody merge this? Thanks!

@mx-psi mx-psi added this pull request to the merge queue May 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2025
@mx-psi mx-psi added this pull request to the merge queue May 6, 2025
Merged via the queue into open-telemetry:main with commit 5ee4816 May 6, 2025
57 of 58 checks passed
@codeboten
Copy link
Contributor

Thanks for this fix @iblancasa, this makes me wonder if at some point we'd be able to switch to using a console exporter to ensure consistency in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource attributes from telemetry.resource are missing for internal logs
7 participants