Skip to content

Bytes based batching for metrics #12550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for metrics.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

@iblancasa iblancasa requested review from bogdandrutu, dmitryax and a team as code owners March 4, 2025 15:21
@iblancasa
Copy link
Contributor Author

#12519 (review)

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 92.45283% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (7d3e03e) to head (aaf9cb1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pmetric/pb.go 0.00% 14 Missing ⚠️
exporter/exporterhelper/metrics_batch.go 97.01% 5 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (92.45%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12550      +/-   ##
==========================================
- Coverage   92.18%   92.16%   -0.02%     
==========================================
  Files         469      471       +2     
  Lines       25394    25561     +167     
==========================================
+ Hits        23409    23558     +149     
- Misses       1574     1591      +17     
- Partials      411      412       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 4, 2025
@dmitryax
Copy link
Member

dmitryax commented Mar 4, 2025

Thanks, @iblancasa. Please adopt the recent changes made in #12548

@iblancasa
Copy link
Contributor Author

@dmitryax can you take a look?

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@github-actions github-actions bot requested a review from bogdandrutu March 10, 2025 11:32
@iblancasa iblancasa force-pushed the metrics-sizer2 branch 2 times, most recently from e09bbe7 to 7a6304e Compare March 10, 2025 11:40
Signed-off-by: Israel Blancas <[email protected]>
@bogdandrutu bogdandrutu enabled auto-merge March 10, 2025 20:36
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 10, 2025
Merged via the queue into open-telemetry:main with commit 6ae1c98 Mar 10, 2025
54 of 55 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
#### Description

This PR implements serialized bytes based batching for metrics.

#### Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Related PRs:
- #12550
- #12519

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants