-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bytes based batching for metrics #12550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (92.45%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12550 +/- ##
==========================================
- Coverage 92.18% 92.16% -0.02%
==========================================
Files 469 471 +2
Lines 25394 25561 +167
==========================================
+ Hits 23409 23558 +149
- Misses 1574 1591 +17
- Partials 411 412 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks, @iblancasa. Please adopt the recent changes made in #12548 |
180478c
to
b257e39
Compare
@dmitryax can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
05745da
to
03dfa56
Compare
e09bbe7
to
7a6304e
Compare
Signed-off-by: Israel Blancas <[email protected]>
7a6304e
to
aaf9cb1
Compare
6ae1c98
#### Description This PR implements serialized bytes based batching for metrics. #### Link to tracking issue #3262 Continuation of #12299 made by @sfc-gh-sili. Related PRs: - #12550 - #12519 Signed-off-by: Israel Blancas <[email protected]>
Description
This PR implements serialized bytes based batching for metrics.
Link to tracking issue
#3262
Continuation of #12299 made by @sfc-gh-sili.