Skip to content

Fix bug where the error logged when conversion of data fails is always nil #12510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Fix bug where the error logged when conversion of data fails is alway…

11227c2
Select commit
Loading
Failed to load commit list.
Merged

Fix bug where the error logged when conversion of data fails is always nil #12510

Fix bug where the error logged when conversion of data fails is alway…
11227c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2025 in 0s

92.11% (target 90.00%)

View this Pull Request on Codecov

92.11% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 65.90909% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (216046a) to head (11227c2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/logs.go 45.45% 4 Missing and 2 partials ⚠️
exporter/exporterhelper/metrics.go 72.72% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/traces.go 72.72% 2 Missing and 1 partial ⚠️
...xporter/exporterhelper/xexporterhelper/profiles.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12510      +/-   ##
==========================================
- Coverage   92.16%   92.11%   -0.06%     
==========================================
  Files         465      467       +2     
  Lines       25201    25252      +51     
==========================================
+ Hits        23226    23260      +34     
- Misses       1576     1590      +14     
- Partials      399      402       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov