Generate assert function for each metric in mdatagen #12179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sincejune
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12179 +/- ##
==========================================
+ Coverage 91.62% 91.80% +0.18%
==========================================
Files 465 465
Lines 24775 25342 +567
==========================================
+ Hits 22699 23266 +567
Misses 1687 1687
Partials 389 389 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 25, 2025
| metricdatatest.AssertEqual(t, want, got, opts...) | ||
| } | ||
|
|
||
| // ensure no additional metrics are emitted | ||
| require.Equal(t, len(expected), lenMetrics(md)) | ||
| } | ||
|
|
||
| func getMetric(name string, got metricdata.ResourceMetrics) metricdata.Metrics { | ||
| {{ range $name, $metric := .Telemetry.Metrics }} | ||
| {{ if not $metric.Optional }} |
There was a problem hiding this comment.
Should we generate for this as well?
FYI: I've never seen a usage of this optional. Can we check if used, otherwise to remove it?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
…#12184) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description A follow-up PR of #12179 , cc @bogdandrutu Note: This PR also removes those metric assertions which is actually testing metrics that doesn't belong to the package. They might be added due to the limitation of the AssertMetrics function. e.g. changes in `processor/memorylimitprocessor/memorylimiter_test.go` <!-- Issue number if applicable --> #### Link to tracking issue Relevant to #12179 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
…12179) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Completion of open-telemetry#12167 , cc @bogdandrutu Updated one test to verify the change, will update the rest ones after this PR merges. <!-- Issue number if applicable --> #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing Added <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.-->
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
…open-telemetry#12184) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description A follow-up PR of open-telemetry#12179 , cc @bogdandrutu Note: This PR also removes those metric assertions which is actually testing metrics that doesn't belong to the package. They might be added due to the limitation of the AssertMetrics function. e.g. changes in `processor/memorylimitprocessor/memorylimiter_test.go` <!-- Issue number if applicable --> #### Link to tracking issue Relevant to open-telemetry#12179 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completion of #12167 , cc @bogdandrutu
Updated one test to verify the change, will update the rest ones after this PR merges.
Link to tracking issue
n/a
Testing
Added
Documentation
Added