Skip to content

Allow passing trace/metric SDK options to componenttest.Telemetry #12166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu force-pushed the setup-telemetry-options branch from 453e46a to 06880cf Compare January 22, 2025 21:36
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 58.97436% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.75%. Comparing base (c6a0986) to head (06880cf).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/telemetry.go 36.84% 11 Missing and 1 partial ⚠️
component/componenttest/obsreporttest.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12166      +/-   ##
==========================================
- Coverage   91.81%   91.75%   -0.06%     
==========================================
  Files         463      463              
  Lines       24741    24759      +18     
==========================================
+ Hits        22715    22717       +2     
- Misses       1644     1658      +14     
- Partials      382      384       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added this pull request to the merge queue Jan 23, 2025
Merged via the queue into open-telemetry:main with commit 7db2f90 Jan 23, 2025
52 of 53 checks passed
@bogdandrutu bogdandrutu deleted the setup-telemetry-options branch January 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants