Skip to content

Support logs scraper #12116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Jan 17, 2025

Description

This PR added support for logs scraper

Link to tracking issue

Relevant to #11238

Testing

Added

Documentation

Added

@sincejune sincejune requested a review from a team as a code owner January 17, 2025 15:22
@sincejune sincejune requested a review from mx-psi January 17, 2025 15:22
@mx-psi mx-psi requested a review from bogdandrutu January 17, 2025 15:39
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (9757ead) to head (62aed12).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scraper/scraperhelper/controller.go 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12116      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         463      463              
  Lines       24819    24862      +43     
==========================================
+ Hits        22767    22804      +37     
- Misses       1670     1674       +4     
- Partials      382      384       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sincejune sincejune force-pushed the support-logs-scraper branch 3 times, most recently from 9cbf911 to 91dfee9 Compare January 18, 2025 06:58
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have examples in which we want the same component to be a metrics scraper and a logs scraper?

@sincejune
Copy link
Contributor Author

Do we have examples in which we want the same component to be a metrics scraper and a logs scraper?

Generally components like database receiver can use metrics/logs scraper in the implementation, but I think it's up to the component owners :)

@sincejune sincejune force-pushed the support-logs-scraper branch from 8cf3541 to 89a3cda Compare January 21, 2025 17:38
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 21, 2025
@sincejune
Copy link
Contributor Author

resolved conflicts in the commit: 62aed12

@bogdandrutu bogdandrutu enabled auto-merge January 22, 2025 04:15
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into open-telemetry:main with commit 6740a28 Jan 22, 2025
52 of 53 checks passed
@sincejune sincejune deleted the support-logs-scraper branch February 11, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants