Deprecate CheckScraperMetrics functions #12105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sincejune
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12105 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 461 461
Lines 24685 24685
=======================================
Hits 22625 22625
Misses 1678 1678
Partials 382 382 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 17, 2025
bogdandrutu
reviewed
Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Remove deprecated CheckScraperMetrics functions <!-- Issue number if applicable --> #### Link to tracking issue Relevant to #12105 <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Bogdan Drutu <[email protected]>
sincejune
changed the title
16 tasks
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Remove deprecated CheckScraperMetrics functions <!-- Issue number if applicable --> #### Link to tracking issue Relevant to open-telemetry#12105 <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating CheckScraperMetrics functions in the untested
obsreporttestandotelcheckergo files.cc @bogdandrutu
Testing
n/a
Documentation
n/a