[debugexporter] Add support for profiles signal #11494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11494 +/- ##
==========================================
+ Coverage 91.38% 91.39% +0.01%
==========================================
Files 433 434 +1
Lines 23659 23711 +52
==========================================
+ Hits 21620 21670 +50
- Misses 1663 1665 +2
Partials 376 376 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Oct 21, 2024
julianocosta89
commented
Oct 22, 2024
bogdandrutu
reviewed
Oct 22, 2024
dmathieu
approved these changes
Oct 23, 2024
mx-psi
reviewed
Oct 23, 2024
…helperprofiles to v0.112.0
mx-psi
approved these changes
Oct 23, 2024
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM. I know there is an open question regarding the format, I think we can go with this and iterate since we can change the output format freely
Member
|
@bogdandrutu Anything left from your side? I intend to merge this by Friday EU morning |
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds Profiles support to the `debugexporter` component. <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#11155. <!--Describe what testing was performed and which tests were added.--> #### Testing Added tests to all modified modules: - `exporter/debugexporter/exporter_test.go` - `exporter/debugexporter/factory_test.go` - `exporter/debugexporter/internal/normal/profiles_test.go`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Profiles support to the
debugexportercomponent.Link to tracking issue
Fixes #11155.
Testing
Added tests to all modified modules:
exporter/debugexporter/exporter_test.goexporter/debugexporter/factory_test.goexporter/debugexporter/internal/normal/profiles_test.go