Skip to content

[confmap] Mark module as stable #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 20, 2024

Fixes #9379.

I removed two TODOs because I think we can just stay with the current behavior, but would want confirmation from @codeboten about this since it's mentioned here #4880 (review)

@mx-psi mx-psi marked this pull request as ready for review August 20, 2024 09:01
@mx-psi mx-psi requested review from a team, djaglowski and codeboten August 20, 2024 09:01
@mx-psi
Copy link
Member Author

mx-psi commented Aug 20, 2024

cc @open-telemetry/collector-approvers

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (e375da4) to head (6afeeab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10920      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +0.01%     
==========================================
  Files         411      411              
  Lines       19330    19330              
==========================================
+ Hits        17760    17762       +2     
+ Misses       1219     1218       -1     
+ Partials      351      350       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that those TODOs are probably not going to get addressed in the foreseeable future and they haven't caused issues thus far.

@mx-psi
Copy link
Member Author

mx-psi commented Aug 21, 2024

From 2024-08-21 meeting, we will merge this by Friday unless somebody blocks this PR

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TylerHelmuth
Copy link
Member

@mx-psi before you merge take a look at #10950. I believe the issue is the result of a regression (when I tested the scenario with 0.90.0 the collector did not panic).

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Aug 26, 2024
@mx-psi mx-psi merged commit e1bb99a into open-telemetry:main Aug 26, 2024
49 checks passed
@mx-psi mx-psi deleted the mx-psi/confmap-1.0 branch August 26, 2024 14:29
@github-actions github-actions bot added this to the next release milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module confmap
6 participants