-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[confmap] Mark module as stable #10920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @open-telemetry/collector-approvers |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10920 +/- ##
==========================================
+ Coverage 91.87% 91.88% +0.01%
==========================================
Files 411 411
Lines 19330 19330
==========================================
+ Hits 17760 17762 +2
+ Misses 1219 1218 -1
+ Partials 351 350 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that those TODOs are probably not going to get addressed in the foreseeable future and they haven't caused issues thus far.
From 2024-08-21 meeting, we will merge this by Friday unless somebody blocks this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #9379.
I removed two TODOs because I think we can just stay with the current behavior, but would want confirmation from @codeboten about this since it's mentioned here #4880 (review)