[confighttp] Add option to include query params in auth context #10445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10445 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 403 403
Lines 18734 18739 +5
=======================================
+ Hits 17298 17303 +5
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
TylerHelmuth
reviewed
Jul 9, 2024
TylerHelmuth
reviewed
Jul 9, 2024
jpkrohling
force-pushed
the
jpkrohling/issue4806
branch
from
6a91f47 to
efeba25
Compare
axw
approved these changes
Jul 19, 2024
This PR adds a new option to the ServerConfig's Auth option, allowing users to specify a list of query parameters to add to the sources of auth data, in addition to HTTP headers. Instead of simply adding all parameters, which might be numeruous, we require users to specify which ones to include. Auth extensions don't need to be changed, but should document which attributes they expect to find in the context and how to configure confighttp to accomplish that. Fixes open-telemetry#4806 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/issue4806
branch
from
efeba25 to
819ef02
Compare
mx-psi
approved these changes
Jul 19, 2024
TylerHelmuth
approved these changes
Jul 19, 2024
github-actions
bot
modified the milestones:
go.opentelemetry.io/collector/confighttp 1.0,
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to the ServerConfig's Auth option, allowing users to specify a list of query parameters to add to the sources of auth data, in addition to HTTP headers. Instead of simply adding all parameters, which might be numeruous, we require users to specify which ones to include.
Auth extensions don't need to be changed, but should document which attributes they expect to find in the context and how to configure confighttp to accomplish that.
Fixes #4806
Signed-off-by: Juraci Paixão Kröhling [email protected]