Skip to content

WIP do not merge - optional config fields #10260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

fix

7157a80
Select commit
Loading
Failed to load commit list.
Closed

WIP do not merge - optional config fields #10260

fix
7157a80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 26, 2025 in 0s

91.79% (target 90.00%)

View this Pull Request on Codecov

91.79% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (d17559b) to head (7157a80).
Report is 535 commits behind head on main.

Files with missing lines Patch % Lines
confmap/optional/optional.go 77.77% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10260      +/-   ##
==========================================
- Coverage   91.80%   91.79%   -0.02%     
==========================================
  Files         424      425       +1     
  Lines       20094    20114      +20     
==========================================
+ Hits        18447    18463      +16     
- Misses       1268     1271       +3     
- Partials      379      380       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.