Skip to content

use WithoutCancel in calls to recording metrics #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codeboten opened this issue Dec 5, 2023 · 0 comments · Fixed by #10397
Closed

use WithoutCancel in calls to recording metrics #9049

codeboten opened this issue Dec 5, 2023 · 0 comments · Fixed by #10397

Comments

@codeboten
Copy link
Contributor

go 1.21 has a WithoutCancel func I would suggest we move to in the future (whenever 1.22 is out). This change removes any context (including baggage), which likely you'd want to keep

Originally posted by @codeboten in #9048 (comment)
@codeboten codeboten mentioned this issue Dec 5, 2023
Merged
codeboten added a commit to codeboten/opentelemetry-collector that referenced this issue Jun 12, 2024
@codeboten
[chore] update code to use WithoutCancel
2481bcd 
This was introduced in go 1.21 and removes the need for a custom implementation of the context.

Fixes open-telemetry#9049

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Jun 12, 2024
Merged
mx-psi pushed a commit that referenced this issue Jun 13, 2024
@codeboten
[chore] update code to use WithoutCancel (#10397)
662a4c4 
This was introduced in go 1.21 and removes the need for a custom
implementation of the context.

Fixes #9049

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] update code to use WithoutCancel codeboten/opentelemetry-collector
1 participant
@codeboten