Skip to content

Review featuregate.FlagValue #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bogdandrutu opened this issue Jan 27, 2023 · 0 comments · Fixed by #7356
Closed

Review featuregate.FlagValue #7042

bogdandrutu opened this issue Jan 27, 2023 · 0 comments · Fixed by #7356
Assignees
@MovieStoreGuy
Labels
area:featuregate
Milestone
go.opentelemetry....

Comments

@bogdandrutu
Copy link
Member

Few caveats that I found so far:

  1. The need of applying the the flag to the registry. Would be good if we can pass a registry to the flag constructor (or Registry.ToFlag something like this API) and when the flags are parsed the values are Set to the Registry.
  2. The "String" represents only the values set in the Flag not all the gates. This can be solved similarly with 1.
  3. This logic seems very strange. I think we should remove this.

Possible solutions for 1.0:

  • Move it from the current package to otelcol and delay the fixes.
  • Fix now.
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 11, 2023
@bogdandrutu
Replace existing featuregate.FlagValue with a direct apply version
f8bdb78 
Fixes open-telemetry#7042

Uses direct values to/from a given registry. Simplifies usage, defers the "set" logic to the Registry.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu mentioned this issue Mar 11, 2023
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 11, 2023
@bogdandrutu
Replace existing featuregate.FlagValue with a direct apply version
74232c8 
Fixes open-telemetry#7042

Uses direct values to/from a given registry. Simplifies usage, defers the "set" logic to the Registry.

Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 11, 2023
@bogdandrutu
Replace existing featuregate.FlagValue with a direct apply version
d86f8ea 
Fixes open-telemetry#7042

Uses direct values to/from a given registry. Simplifies usage, defers the "set" logic to the Registry.

Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 11, 2023
@bogdandrutu
Replace existing featuregate.FlagValue with a direct apply version
87ba0ca 
Fixes open-telemetry#7042

Uses direct values to/from a given registry. Simplifies usage, defers the "set" logic to the Registry.

Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit that referenced this issue Mar 13, 2023
@bogdandrutu
Replace existing featuregate.FlagValue with a direct apply version (#…
a70c017 
…7356)

Fixes #7042

Uses direct values to/from a given registry. Simplifies usage, defers the "set" logic to the Registry.

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MovieStoreGuy MovieStoreGuy

Labels
area:featuregate
Projects
None yet
Milestone
go.opentelemetry.io/collector/feature...
3 participants
@bogdandrutu @mx-psi @MovieStoreGuy