Skip to content

Add ReadHeaderTimeout values #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeboten opened this issue Jul 18, 2022 · 0 comments · Fixed by #10675
Closed

Add ReadHeaderTimeout values #5699

codeboten opened this issue Jul 18, 2022 · 0 comments · Fixed by #10675
Labels
release:required-for-ga Must be resolved before GA release

Comments

@codeboten
Copy link
Contributor

The following lint errors started showing up after the latest upgrade to golangci-lint:

golangci-lint run
config/confighttp/confighttp.go:321:10: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
        return &http.Server{
                Handler: handler,
        }, nil
config/confighttp/compression_test.go:106:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
                        srv := &http.Server{
                                Handler: handler,
                        }
config/confighttp/compression_test.go:204:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
                        srv := &http.Server{
                                Handler: httpContentDecompressor(handler),
                        }
make: *** [lint] Error 1
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jul 18, 2022
Disabling G112 until open-telemetry#5699 has been addressed.
codeboten pushed a commit that referenced this issue Jul 18, 2022
Disabling G112 until #5699 has been addressed.
@atoulme atoulme added the release:required-for-ga Must be resolved before GA release label Dec 19, 2023
@mx-psi mx-psi moved this to Todo in Collector: v1 Apr 18, 2024
@crobert-1 crobert-1 moved this from Todo to In Progress in Collector: v1 Jul 17, 2024
@mx-psi mx-psi closed this as completed in 2c9229d Aug 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Collector: v1 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment