Skip to content

Revert "[chore] Add dockerhub metadata with links to readme files (#8… #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerHelmuth
Copy link
Member

…73)"

This reverts commit 101c9dd.

This commit added the dockerhub section to the goreleaser config but didn't set a username, which broke the release process: https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/14197524938/job/39776413907

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner April 1, 2025 14:21
@TylerHelmuth TylerHelmuth added this pull request to the merge queue Apr 1, 2025
Merged via the queue into open-telemetry:main with commit 11d45f2 Apr 1, 2025
70 checks passed
@TylerHelmuth TylerHelmuth deleted the tyler.revert-dockerhub-section branch April 1, 2025 15:16
@mowies
Copy link
Member

mowies commented Apr 10, 2025

I found my mistake for this: theDOCKER_USERNAME and DOCKER_PASSWORD are not set in the environment but only in the secrets, so those variables would need to be added.

Then the otelbot user would be used to update info on the dockerhub page. The question is if that user has enough privileges to do so. I don't think i can check that by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants