Skip to content

[chore] Remove unneeded build combinations and inconsistencies #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2025
Merged

[chore] Remove unneeded build combinations and inconsistencies #850

merged 6 commits into from
Mar 4, 2025

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 4, 2025 •
edited
Loading

This PR

  • removes the build combinations darwin/ppc64le and windows/ppc64le because they are not supported by Go and no artifacts of any sort are generated from them.
  • makes pipeline naming more consistent
    • Continuous Integration -> CI
    • renamed builder pipelines to adhere to same naming scheme as collector distros

Fixes #838

@mowies mowies changed the title remove unneeded build combinations from pipelines [chore] Remove unneeded build combinations from pipelines Mar 4, 2025
@mowies mowies changed the title [chore] Remove unneeded build combinations from pipelines [chore] Remove unneeded build combinations from pipeline Mar 4, 2025
@mowies mowies changed the title [chore] Remove unneeded build combinations from pipeline [chore] Remove unneeded build combinations from pipelines Mar 4, 2025
@mowies mowies changed the title [chore] Remove unneeded build combinations from pipelines [chore] Remove unneeded build combinations and inconsistencies Mar 4, 2025
@mowies mowies force-pushed the goreleaser-cleanup branch from 33b7896 to 7c60579 Compare March 4, 2025 15:09
@mowies mowies marked this pull request as ready for review March 4, 2025 15:15
@mowies mowies requested a review from a team as a code owner March 4, 2025 15:15
@mowies mowies requested a review from douglascamata March 4, 2025 15:20
evan-bradley
evan-bradley approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I validated the allowed GOOS and GOARCH combinations with this list: https://go.dev/doc/install/source#environment

songy23
songy23 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evan-bradley evan-bradley added this pull request to the merge queue Mar 4, 2025
Merged via the queue into open-telemetry:main with commit bee27c3 Mar 4, 2025
47 checks passed
@evan-bradley evan-bradley deleted the goreleaser-cleanup branch March 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@douglascamata douglascamata Awaiting requested review from douglascamata

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unneeded OS/Arch combinations
3 participants
@mowies @songy23 @evan-bradley