Skip to content

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Dec 5, 2025

#1293 is facing some hold-ups due to getting CLA approval (see #1289 (comment)). This is a clean-room (I promise, though only so many ways to write this :D) of that PR.

@SquidDev SquidDev requested a review from a team as a code owner December 5, 2025 09:51
@SquidDev SquidDev requested a review from ChrsMark December 5, 2025 09:51
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@atoulme atoulme self-requested a review December 5, 2025 13:54
@atoulme
Copy link
Contributor

atoulme commented Dec 5, 2025

Ouch, that's not quite it. This PR needs retooling - please add the systemdreceiver to the systemd receiver block. Remove systemdexporter.

@SquidDev
Copy link
Contributor Author

SquidDev commented Dec 5, 2025

Ahhh. Sorry, this is what I get for writing code before breakfast. Will get that fixed :)

@SquidDev
Copy link
Contributor Author

SquidDev commented Dec 5, 2025

Fixed! Have run make build this time to confirm it actually works.

@atoulme atoulme added this pull request to the merge queue Dec 9, 2025
Merged via the queue into open-telemetry:main with commit 38c786f Dec 9, 2025
35 checks passed
@SquidDev
Copy link
Contributor Author

SquidDev commented Dec 9, 2025

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants