Skip to content

[chore] enable modernize linter #44199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codeboten merged 49 commits into from
Dec 18, 2025
Merged

[chore] enable modernize linter #44199

codeboten merged 49 commits into from
Dec 18, 2025

Conversation

@paulojmdias
Copy link
Member

@paulojmdias paulojmdias commented Nov 12, 2025 •
edited
Loading

Description

This PR enables the modernize linter.

Should only be merged when the following PRs are merged:

Example of a linter error:

WARN [runner/exclusion_paths] The pattern "third_party" match no issues
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Text: "cachedBytes", Path: "pagefile.go", Linters: "unused"]
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "third_party", Linters: "gci, gofumpt"]
receiver/googlecloudspannerreceiver/config.go:97:2: slicescontains: Loop can be simplified using slices.Contains (modernize)
	for _, database := range instance.Databases {
	^
receiver/googlecloudspannerreceiver/internal/filter/testhelpers_test.go:40:6: rangeint: for loop can be modernized using range over int (modernize)
	for i := 0; i < 3; i++ {
	    ^
receiver/googlecloudspannerreceiver/internal/statsreader/timestampsgenerator_test.go:71:6: rangeint: for loop can be modernized using range over int (modernize)
	for i := 0; i < expectedAmountOfTimestamps; i++ {
	    ^
make: *** [lint] Error 1

Fixes #44364

This was referenced Nov 12, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
songy23 pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/aerospikereceiver] run make modernize (#44206)
f0aba1f 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
bogdandrutu pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/prometheusremotewritereceiver] run make modernize (#…
4f9767a 
…44213)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
bogdandrutu pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/fluentforwardreceiver] run make modernize (#44210)
09f7fc4 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
bogdandrutu pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/cloudfoundryreceiver] run make modernize (#44209)
9360d8a 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
songy23 pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/azuremonitorreceiver] run make modernize (#44207)
0a298b5 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
songy23 pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/googlecloudmonitoringreceiver] run make modernize (#…
724d5e0 
…44211)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
songy23 pushed a commit that referenced this pull request Nov 12, 2025
@paulojmdias
[chore][receiver/ciscoosreceiver] run make modernize (#44208)
a9ee55a 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
This was referenced Nov 12, 2025
Closed
Merged
Merged
Merged
songy23 pushed a commit that referenced this pull request Nov 13, 2025
@paulojmdias
[chore][receiver/windowseventlogreceiver] improve linting (#44224)
f9a3301 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is part of the process to enable the
[modernize](#44199)
linter in CI and upgrade `golanglint` to the latest version.

There are no changes in the component behaviour.

```sh
WARN [runner/exclusion_paths] The pattern "third_party" match no issues
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Text: "cachedBytes", Path: "pagefile.go", Linters: "unused"]
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "third_party", Linters: "gci, gofumpt"]
receiver/windowseventlogreceiver/factory_test.go:45:3: error-is-as: use assert.ErrorIs or assert.ErrorAs depending on the case (testifylint)
		assert.IsType(t, pipeline.ErrSignalNotSupported, err)
		^
make: *** [lint] Error 1
```

---------

Signed-off-by: Paulo Dias <[email protected]>
songy23 pushed a commit that referenced this pull request Nov 13, 2025
@paulojmdias
[chore][exporter/datasetexporter] run make modernize (#44226)
60f14a6 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
codeboten pushed a commit that referenced this pull request Nov 13, 2025
@paulojmdias
[chore][processor/resourcedetectionprocessor] improve linting (#44225)
791ad36 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is part of the process to enable the
[modernize](#44199)
linter in CI and upgrade `golanglint` to the latest version.

There are no changes in the component behaviour.

```sh
WARN [runner/exclusion_paths] The pattern "third_party" match no issues
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Text: "cachedBytes", Path: "pagefile.go", Linters: "unused"]
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "third_party", Linters: "gci, gofumpt"]
processor/resourcedetectionprocessor/config.go:50:2: deprecatedComment: `Deprecated: ` notices should be in a dedicated paragraph, separated from the rest (gocritic)
	// Deprecated: Please use detector's resource_attributes config instead
	^
make: *** [lint] Error 1
```

Signed-off-by: Paulo Dias <[email protected]>
codeboten pushed a commit that referenced this pull request Nov 13, 2025
@paulojmdias
[chore][exporter/bmchelixexporter] run make modernize (#44203)
76bc969 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI which needs upgrade the `golanglint` to `v2.6.1`.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>
codeboten pushed a commit that referenced this pull request Nov 13, 2025
@paulojmdias
[chore][processor/isolationforestprocessor] run make modernize (#44204)
458e9b3 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](#44199)
linter in CI.

There are no changes in the component behaviour.

---------

Signed-off-by: Paulo Dias <[email protected]>
This was referenced Nov 13, 2025
Merged
Merged
codeboten
codeboten reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the exceptions here have issues associate with them make sure they're eventually removed?

@paulojmdias @codeboten
Update .golangci.yml
5613cac 
Co-authored-by: Alex Boten <[email protected]>
This was referenced Dec 16, 2025
Open
Open
Open
Open
Open
Open
Open
@paulojmdias
Copy link
Member Author

paulojmdias commented Dec 16, 2025

should the exceptions here have issues associate with them make sure they're eventually removed?

Agree. Issues created:

codeboten
codeboten reviewed Dec 18, 2025
View reviewed changes
codeboten
codeboten reviewed Dec 18, 2025
View reviewed changes
@codeboten codeboten merged commit 3395018 into open-telemetry:main Dec 18, 2025
189 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 18, 2025
@paulojmdias
Copy link
Member Author

paulojmdias commented Dec 18, 2025

Thank you @codeboten 🙏

@paulojmdias paulojmdias deleted the chore/enable_modernize_lint branch December 18, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeboten codeboten codeboten approved these changes

@dehaansa dehaansa Awaiting requested review from dehaansa dehaansa is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@MikeGoldsmith MikeGoldsmith Awaiting requested review from MikeGoldsmith

Assignees

@TylerHelmuth TylerHelmuth

Labels

internal/tools processor/logdedup

Projects

None yet

Milestone

next release

Development

Successfully merging this pull request may close these issues.

Add modernize to golint

4 participants

@paulojmdias @constanca-m @codeboten @TylerHelmuth