Allow Collector to be run as a Windows Service & add MSI build step #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
commented
Jul 8, 2020
cmd/otelcontribcol/main.go
Outdated
| // OpenTelemetry Service. | ||
| // Program otelcontribcol is an extension to the OpenTelemetry Collector | ||
| // that includes additional, somtimes vendor-specific components | ||
| // contributed from the wider community. |
There was a problem hiding this comment.
^ I assume that was just an outdated comment?
james-bebbington
force-pushed
the
windows-msi
branch
4 times, most recently
from
352133d to
a1db209
Compare
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 84.02% 83.97% -0.06%
==========================================
Files 178 179 +1
Lines 9529 9535 +6
==========================================
Hits 8007 8007
- Misses 1196 1202 +6
Partials 326 326
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
windows-msi
branch
from
a1db209 to
9df4d2b
Compare
bogdandrutu
approved these changes
Jul 8, 2020
…ce & added build step for generating Windows MSI
james-bebbington
force-pushed
the
windows-msi
branch
from
9df4d2b to
d4e411a
Compare
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
…ce & added build step for generating Windows MSI (#408)
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
this is a small fix of a single typo that triggered my OCD ;-) Co-authored-by: Liz Fong-Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying same changes from Core in these three PRs:
One very minor differences from the Core PR: I used
fmt.Errorf("... : %w", err)instead oferrors.Wrap(err, "...")as I saw a comment saying we want to move towards that convention