[receiver/sqlserver] Remove duplicated flags for enabling top query c… #40416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollection and query sample collection
github-actions
bot
added
receiver/sqlserver
Run Windows
atoulme
reviewed
Jun 4, 2025
atoulme
approved these changes
Jun 4, 2025
crobert-1
approved these changes
Jun 4, 2025
Comment on lines
19
to
20
| Removed `top_query_collection.enabled` in favor of `events."db.server.top_query".enabled` in top query collection. | ||
| Removed `query_sample_collection.enabled` in favor of `events."db.server.query_sample".enabled` in query sample collection. |
There was a problem hiding this comment.
Can we re-word this to say rename instead of Removed ... in favor of ...? (Unless there's more of a difference here)
Co-authored-by: Antoine Toulme <[email protected]>
sincejune
commented
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ollection and query sample collection
Description
top_query_collection.enabledin favor ofevents."db.server.top_query".enabledin top query collection.query_sample_collection.enabledin favor ofevents."db.server.query_sample".enabledin query sample collection.Link to tracking issue
n/a
Testing
Updated
Documentation
Added