Skip to content

Add resource metrics cache cleanup #39957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perebaj
Copy link
Contributor

@perebaj perebaj commented May 8, 2025

Description

Add LRU to improve the cache cleanup and avoid memory leak through prw requests

Link to tracking issue

Related to #37277

Testing

Documentation

@perebaj perebaj marked this pull request as ready for review May 25, 2025 17:09
@perebaj perebaj requested a review from a team as a code owner May 25, 2025 17:09
@ArthurSens
Copy link
Member

Could you add documentation to our README explaining this behavior? I believe this is something we'll need to communicate to users :)

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the PR is looking great! I have a few suggestions on wording and it looks like you made a dependency downgrade by accident 🤔

After fixing those, the PR should be ready to merge :)

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurSens ArthurSens added the ready to merge Code review completed; ready to merge by maintainers label May 26, 2025
@songy23
Copy link
Member

songy23 commented May 27, 2025

please rebase

@perebaj
Copy link
Contributor Author

perebaj commented May 27, 2025

Rebased, but I commit some wrong versions... fixing

@songy23 songy23 merged commit 0afd75f into open-telemetry:main May 28, 2025
189 of 191 checks passed
@github-actions github-actions bot added this to the next release milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/prometheusremotewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants