-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add resource metrics cache cleanup #39957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource metrics cache cleanup #39957
Conversation
Could you add documentation to our README explaining this behavior? I believe this is something we'll need to communicate to users :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the PR is looking great! I have a few suggestions on wording and it looks like you made a dependency downgrade by accident 🤔
After fixing those, the PR should be ready to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
please rebase |
Rebased, but I commit some wrong versions... fixing |
Description
Add LRU to improve the cache cleanup and avoid memory leak through prw requests
Link to tracking issue
Related to #37277
Testing
Documentation