Skip to content

[chore][postgresqlreceiver] do not report record if the total exec time is not changed #39942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2025

Conversation

cuichenli
Copy link
Contributor

Description

the current implementation would report queries not executed between the last elapsed time. which is not ideal. it would flush the downstream. this change will avoid the issue.

Testing

Documentation

@cuichenli cuichenli requested a review from a team as a code owner May 8, 2025 03:03
@cuichenli cuichenli requested a review from atoulme May 8, 2025 03:03
@github-actions github-actions bot requested a review from antonblock May 8, 2025 03:03
@cuichenli cuichenli changed the title [chore/postgresqlreceiver] do not report record if the total exec time is not changed [chore][postgresqlreceiver] do not report record if the total exec time is not changed May 8, 2025
@atoulme
Copy link
Contributor

atoulme commented May 8, 2025

@antonblock please review as codeowner

@dehaansa dehaansa added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels May 20, 2025
@dehaansa dehaansa removed the ready to merge Code review completed; ready to merge by maintainers label May 20, 2025
Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserved a changelog, then it should be ready to merge!

@cuichenli
Copy link
Contributor Author

This deserved a changelog, then it should be ready to merge!

added, thanks!

@cuichenli cuichenli requested a review from dehaansa May 20, 2025 01:27
@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label May 20, 2025
@mx-psi mx-psi merged commit 9c15778 into open-telemetry:main May 20, 2025
184 checks passed
@github-actions github-actions bot added this to the next release milestone May 20, 2025
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
…me is not changed (open-telemetry#39942)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

the current implementation would report queries not executed between the
last elapsed time. which is not ideal. it would flush the downstream.
this change will avoid the issue.

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/postgresql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants