[receiver/sqlserver] Update event properties #39868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/sqlserver
Run Windows
XSAM
approved these changes
May 6, 2025
crobert-1
reviewed
May 6, 2025
Comment on lines
19
to
20
| * Update event name of top query event to `db.server.top_query` | ||
| * Update event name of query sample event to `db.server.query_sample` |
There was a problem hiding this comment.
Can we make it more obvious what's changing here? Including the original name would be helpful.
Sorry, didn't notice that CI was failing. Fixed them all now. |
crobert-1
approved these changes
May 7, 2025
crobert-1
added
the
ready to merge
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description * Update event name of top query event to `db.server.top_query` * Update event name of query sample event to `db.server.query_sample` * Remove body of query sample event * Rename `sqlserver.username` to `user.name` in query sample event <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing Updated <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
db.server.top_querydb.server.query_samplesqlserver.usernametouser.namein query sample eventLink to tracking issue
n/a
Testing
Updated
Documentation
Added