Skip to content

pkg/stanza/fileconsumer: remove new file log when the noStateTracker is used #39861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ridwanmsharif
Copy link
Member

Description

Add to the interface to be able to identify which tracker is being used. Also mute the log when no state is tracked.

Link to tracking issue

Fixes #39855

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/mute-log branch from 3ae232a to 07be66e Compare May 5, 2025 20:54
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fair solution from my standpoint. I'm not going to formally hit approve since I'd like to make sure component owners are okay with the solution, but code-wise I think it LGTM.

@djaglowski djaglowski merged commit 61f8c78 into open-telemetry:main May 7, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone May 7, 2025
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
…is used (open-telemetry#39861)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add to the interface to be able to identify which tracker is being used.
Also mute the log when no state is tracked.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes open-telemetry#39855

Signed-off-by: Ridwan Sharif <[email protected]>
Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the ReplayFIle option in the otlpjsonfilereceiver, we get spammy logs
4 participants