[receiver/googlecloudpubsub] add ignore_encoding_error configuration #39839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2025
atoulme
reviewed
May 5, 2025
| @@ -0,0 +1,16 @@ | |||
| change_type: enhancement | |||
There was a problem hiding this comment.
breaking if you add a new metric enabled by default.
There was a problem hiding this comment.
I've changed the release note. Is this stated somewhere that a new metric is a breaking change? I like to read the guidelines to make better release notes, I didn't see this stated in the CONTRIBUTING.md file.
There was a problem hiding this comment.
atoulme
approved these changes
May 5, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…pen-telemetry#39839) #### Description Introduce a setting to ignore errors when the configured encoder. It's advised to set this to `true` when using a custom encoder, and use `receiver.googlecloudpubsub.encoding_error` metric to monitor the number of errors. Ignoring the error will cause the receiver to drop the message. #### Link to tracking issue open-telemetry#38164 #### Testing Tested with a custom encoder and introducing bogus message to the topic. #### Documentation Added the configuration setting to the README
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
…pen-telemetry#39839) #### Description Introduce a setting to ignore errors when the configured encoder. It's advised to set this to `true` when using a custom encoder, and use `receiver.googlecloudpubsub.encoding_error` metric to monitor the number of errors. Ignoring the error will cause the receiver to drop the message. #### Link to tracking issue open-telemetry#38164 #### Testing Tested with a custom encoder and introducing bogus message to the topic. #### Documentation Added the configuration setting to the README
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…pen-telemetry#39839) #### Description Introduce a setting to ignore errors when the configured encoder. It's advised to set this to `true` when using a custom encoder, and use `receiver.googlecloudpubsub.encoding_error` metric to monitor the number of errors. Ignoring the error will cause the receiver to drop the message. #### Link to tracking issue open-telemetry#38164 #### Testing Tested with a custom encoder and introducing bogus message to the topic. #### Documentation Added the configuration setting to the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a setting to ignore errors when the configured encoder. It's advised to set this to
truewhen usinga custom encoder, and use
receiver.googlecloudpubsub.encoding_errormetric to monitor the number of errors.Ignoring the error will cause the receiver to drop the message.
Link to tracking issue
#38164
Testing
Tested with a custom encoder and introducing bogus message to the topic.
Documentation
Added the configuration setting to the README