Skip to content

Append reference links to metric descriptions in metadata.yaml #39792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raunaqgupta
Copy link

@raunaqgupta raunaqgupta commented Apr 30, 2025

Description

This PR aims to append reference links to metric descriptions in receiver/k8sclusterreceiver/metadata.yaml to sections within the k8s API reference v1.23

This is in accordance to existing links in descriptions of certain metrics. For example:

description: Resource requested for the container. See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#resourcerequirements-v1-core for details

@github-actions github-actions bot requested a review from povilasv April 30, 2025 19:47
@raunaqgupta raunaqgupta changed the title Update metadata.yaml Append references link to metric descriptions in metadata.yaml Apr 30, 2025
@raunaqgupta raunaqgupta changed the title Append references link to metric descriptions in metadata.yaml Append reference links to metric descriptions in metadata.yaml May 6, 2025
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 8, 2025
@atoulme
Copy link
Contributor

atoulme commented May 8, 2025

You might need to regenerate the code. Try make generate from the root of your checkout.

@atoulme atoulme marked this pull request as draft May 8, 2025 00:47
@atoulme
Copy link
Contributor

atoulme commented May 8, 2025

Moving to draft while you address the feedback.

Copy link

linux-foundation-easycla bot commented May 9, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@raunaqgupta raunaqgupta marked this pull request as ready for review May 9, 2025 19:56
@povilasv
Copy link
Contributor

Tests are failing:

    e2e_test.go:180: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/k8sclusterreceiver/e2e_test.go:181
        	            				/opt/hostedtoolcache/go/1.23.8/x64/src/runtime/asm_amd64.s:1700
        	Error:      	Received unexpected error:
        	            	the following errors occurred:
        	            	 -  resource "map[k8s.hpa.name:test-k8scluster-receiver-hpa k8s.hpa.uid:* k8s.namespace.name:my-namespace]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver": metric "k8s.hpa.current_replicas": description doesn't match expected: Current number of pod replicas managed by this autoscaler., actual: Current number of pod replicas managed by this autoscaler. See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.33/#horizontalpodautoscalerstatus-v1-autoscaling for details.
        	            	 -  resource "map[k8s.hpa.name:test-k8scluster-receiver-hpa k8s.hpa.uid:* k8s.namespace.name:my-namespace]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver": metric "k8s.hpa.desired_replicas": description doesn't match expected: Desired number of pod replicas managed by this autoscaler., actual: Desired number of pod replicas managed by this autoscaler. See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.33/#horizontalpodautoscalerstatus-v1-autoscaling for details.
        	            	 -  resource "map[k8s.hpa.name:test-k8scluster-receiver-hpa k8s.hpa.uid:* k8s.namespace.name:my-namespace]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver": metric "k8s.hpa.max_replicas": description doesn't match expected: Maximum number of replicas to which the autoscaler can scale up., actual: Maximum number of replicas to which the autoscaler can scale up. See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.33/#horizontalpodautoscalerspec-v1-autoscaling for details.
        	            	 -  resource "map[k8s.hpa.name:test-k8scluster-receiver-hpa k8s.hpa.uid:* k8s.namespace.name:my-namespace]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver": metric "k8s.hpa.min_replicas": description doesn't match expected: Minimum number of replicas to which the autoscaler can scale up., actual: Minimum number of replicas to which the autoscaler can scale up. See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.33/#horizontalpodautoscalerspec-v1-autoscaling for details.
    e2e_test.go:180: 
    ```
    
    You need to update e2e too 

@raunaqgupta
Copy link
Author

raunaqgupta commented May 13, 2025

@raunaqgupta Update file: receiver/k8sclusterreceiver/testdata/e2e/cluster-scoped/expected.yaml to fix failing e2e tests

@djaglowski djaglowski removed their assignment May 19, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants