[exporter/datadog] fix a race in serializer #39669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
commented
Apr 25, 2025
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr and
mx-psi
mx-psi
approved these changes
Apr 28, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
#### Description Fix a race condition in metric serializer exporter where the exporter may not be fully initialized when it receives metrics #### Link to tracking issue Fixes open-telemetry#39601 #### Testing ran the test 100 times with no failures ``` go test -run TestNewExporter_Serializer -count 100 -timeout 1h ... PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter 513.392s ```
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
#### Description Fix a race condition in metric serializer exporter where the exporter may not be fully initialized when it receives metrics #### Link to tracking issue Fixes open-telemetry#39601 #### Testing ran the test 100 times with no failures ``` go test -run TestNewExporter_Serializer -count 100 -timeout 1h ... PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter 513.392s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a race condition in metric serializer exporter where the exporter may not be fully initialized when it receives metrics
Link to tracking issue
Fixes #39601
Testing
ran the test 100 times with no failures