Skip to content

[connector/spanmetrics] Deprecate the unused configuration DimensionsCacheSize #39648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

[connector/spanmetrics] Deprecate the unused configuration DimensionsCacheSize #39648

merged 5 commits into from
Apr 25, 2025

Conversation

Frapschen
Copy link
Contributor

Description

fix: #39646

@Frapschen Frapschen requested a review from a team as a code owner April 25, 2025 08:07
@Frapschen Frapschen requested a review from atoulme April 25, 2025 08:07
This was referenced Apr 25, 2025
Closed
Closed
iblancasa
iblancasa approved these changes Apr 25, 2025
View reviewed changes
@iblancasa
Copy link
Contributor

iblancasa commented Apr 25, 2025 •
edited
Loading

LGTM, just a nit. Also, fix CI

@iblancasa iblancasa mentioned this pull request Apr 25, 2025
Closed
@Frapschen
Copy link
Contributor Author

the warn log will look like:

2025-04-26T00:10:25.806+0800    warn    [email protected]/connector.go:111  DimensionsCacheSize is deprecated, please use AggregationCardinalityLimit instead.      {"otelcol.component.id": "spanmetrics", "otelcol.component.kind": "connector", "otelcol.signal": "traces", "otelcol.signal.output": "metrics"}

@Frapschen Frapschen mentioned this pull request Apr 25, 2025
Merged
@atoulme atoulme merged commit 1d452e5 into open-telemetry:main Apr 25, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 25, 2025
@Frapschen Frapschen deleted the fix-issue-39646 branch April 25, 2025 18:20
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
@Frapschen @vincentfree
[connector/spanmetrics] Deprecate the unused configuration Dimensions…
5232566 
…CacheSize (open-telemetry#39648)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
fix:
open-telemetry#39646
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 20, 2025
@Frapschen @vincentfree
[connector/spanmetrics] Deprecate the unused configuration Dimensions…
142f560 
…CacheSize (open-telemetry#39648)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
fix:
open-telemetry#39646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@iblancasa iblancasa iblancasa approved these changes

@portertech portertech Awaiting requested review from portertech

Assignees

@ArthurSens ArthurSens

Labels
connector/spanmetrics
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

Deprecate the unused configuration DimensionsCacheSize
4 participants
@Frapschen @iblancasa @atoulme @ArthurSens